Adopt ShellSyntaxTree 0.3.3 path facts - #1915
Merged
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
August 13, 2026 04:46
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+353
to
+366
| foreach (var argument in occurrence.Arguments) | ||
| { | ||
| if (argument.Argument.IsPath) | ||
| continue; | ||
|
|
||
| var authoredDirectories = ResolveAuthoredFileSystemDirectories( | ||
| argument.AuthoredFileSystemValue, | ||
| clauseWorkingDirectory, | ||
| pathStyle); | ||
| if (authoredDirectories is null) | ||
| return null; | ||
|
|
||
| directories.AddRange(authoredDirectories); | ||
| } |
Comment on lines
+137
to
+139
| var root = Path.Combine( | ||
| Path.GetTempPath(), | ||
| $"netclaw-authored-loop-{Guid.NewGuid():N}"); |
| var root = Path.Combine( | ||
| Path.GetTempPath(), | ||
| $"netclaw-authored-loop-{Guid.NewGuid():N}"); | ||
| var projectDirectory = Path.Combine(root, "project"); |
| Path.GetTempPath(), | ||
| $"netclaw-authored-loop-{Guid.NewGuid():N}"); | ||
| var projectDirectory = Path.Combine(root, "project"); | ||
| var externalDirectory = Path.Combine(root, "external"); |
| $"netclaw-authored-loop-{Guid.NewGuid():N}"); | ||
| var projectDirectory = Path.Combine(root, "project"); | ||
| var externalDirectory = Path.Combine(root, "external"); | ||
| var externalFile = Path.Combine(externalDirectory, "secret.txt"); |
| var projectDirectory = Path.Combine(root, "project"); | ||
| var externalDirectory = Path.Combine(root, "external"); | ||
| var externalFile = Path.Combine(externalDirectory, "secret.txt"); | ||
| var link = Path.Combine(projectDirectory, "link.txt"); |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExactorFiniteSetauthored filesystem facts.ToolPathPolicyand approval scope checks.Result
D14 no longer becomes complex only because it contains a static
forloop. A typedcatgrant can cover it after all paths pass policy. Paths beneath the command cwd use one cwd scope. External paths keep exact scopes. Symlink paths fail closed.Netclaw adds no executable-private parser. ShellSyntaxTree owns the
catoperand fact. Netclaw owns path policy and authority.Validation
ShellSyntaxTree/0.3.3.0169105e....86820494.Native Windows CI remains a merge gate.